add: support for old version of safari version 16 without break thing#14
add: support for old version of safari version 16 without break thing#14hiepxanh wants to merge 2 commits intosyntax-tree:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
|
Appreciate you trying your hand at this! CI is failing. That could be solved. But importantly, in the other thread, I linked to and directly mentioned that “Different regex will be a performance problem for older browser”. This is important. I meant that as a blocker. Your PR is essentially the same as for people who want to use old versions, to also use old versions. They can do that if they want/have to. |
|
Happy new year 2025! <3 Thanks for the feedback! Regarding the regex concern and the linked thread, I understand your point about performance on older browsers. That’s a valid blocker, I see your perspective. My intent was to provide a balance, but I’ll rethink the approach to align more closely with the broader goals of the project. Thanks again for flagging these points! I understand now and we should keep your ways as it is the best as it could. Anyway, I love your plugin and all your ecosystem you build, really appreciate this, thank you so much |
This comment has been minimized.
This comment has been minimized.
|
Happy new year Hiep! :) |
Initial checklist
Description of changes
as we discuss about "negative lookbehind" not working on old version safari in this issue: #10
I try to update it:
the test is simple and running before we do anything else:
the result is fine:
The before change test:

The after change test:

I also try to install nodejs 16 but it not work, so I realize I cannot use many new syntax since nodejs 16 not support. Then I understand why you want to skip support.
I also try to build, to replace my current code to test on my ios, but the node_modules not found the autolink-literal since it is very deep link. I will try to test futher on ios 16.
I hope you can give me some thought about my idea. I don't mind if it useless and should not be merge, since I'm not have many experience. I would like to here what you think.
Thank you <3